Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose Python/Groovy version to clients #5970

Merged

Conversation

devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Aug 22, 2024

  • Sets groovy.version configuration property, as sourced from class groovy.lang.GroovyShell.
  • Sets python.version configuration property, as sourced from python code platform.python_version()
  • Adds groovy.version and python.version to client.configuration.list in dh-defaults.prop (to be returned to client as part of ConfigService.GetConfigurationConstants gRPC)
  • Adds io.deephaven.client.examples.PrintConfigurationConstants to invoke and print out results of ConfigService.GetConfigurationConstants

Fixes #5938

* Sets `groovy.version` configuration property, as sourced from class `groovy.lang.GroovyShell`.
* Sets `python.version` configuration property, as sourced from python code `platform.python_version()`
* Adds `groovy.version` and `python.version` to `client.configuration.list` in dh-defaults.prop (to be returned to client as part of `ConfigService.GetConfigurationConstants` gRPC)
* Adds `io.deephaven.client.examples.PrintConfigurationConstants` to print invoke and print out results of `ConfigService.GetConfigurationConstants`

Fixes deephaven#5938
@devinrsmith devinrsmith added this to the 0.37.0 milestone Aug 22, 2024
@devinrsmith devinrsmith self-assigned this Aug 22, 2024
@devinrsmith
Copy link
Member Author

Here's the output:

file.separator=/
barrage.version=0.6.0
http.session.durationMs=300000
web.webgl.editable=true
web.storage.layout.directory=/layouts
java.version=21.0.4
deephaven.version=0.37.0-SNAPSHOT
groovy.version=3.0.22
web.webgl=true
python.version=3.12.4
web.storage.notebook.directory=/notebooks

@niloc132
Copy link
Member

niloc132 commented Aug 22, 2024

Keep in mind two assumptions this imposes:

  • ConfigService must always initialize before any PythonDeephavenSession I'm mistaken, this isn't required
  • Exactly one PythonDeephavenSession (no chance of multiple sessions with potentially different versions)

@devinrsmith
Copy link
Member Author

ConfigService must always initialize before any PythonDeephavenSession

I don't think this is correct. io.deephaven.server.config.ConfigServiceGrpcImpl#getConfigurationConstants checks Configuration at runtime, not construction time. The construction time is only to prime the class-based versions.

@devinrsmith devinrsmith merged commit 6521382 into deephaven:main Aug 22, 2024
22 checks passed
@devinrsmith devinrsmith deleted the add-groovy-python-version-property branch August 22, 2024 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Python/Groovy version to web client
2 participants