Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csharp): A Windows Installer for the Deephaven Excel Add-In #6378

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Nov 15, 2024

This PR contains a few related items:

  1. The Advanced Installer project file (csharp/ExcelAddInInstaller/ExcelAddInInstaller.aip). This is not expected to be human-readable
  2. Config changes to the ExcelAddIn project to make it only build a 64 bit version of the Excel Add-In (also to change its name)
  3. Code in C# to add "Custom Actions" to our Advanced Installer project. The purpose of this is to let us edit the Windows Registry in a nice way in order to add our add-in to the list of Excel Add-ins (or to remove it)
  4. Please note MsiSession.cs is boilerplate code provided by Advanced Installer. I didn't write it and we (probably) shouldn't touch it
  5. TestCustomActions, a tiny amount of C# code used to manually (!) test the registry manipulation library to see if it's doing the right thing.
  6. deephaven.cer, the public key part of our signing key. Advanced Installer puts this key into the Local User's "Trusted Publishers" list, if the user opts to do so.

You may also want to review m Confluence writeup:
https://deephaven.atlassian.net/wiki/spaces/ED/pages/152862817/Creating+a+Windows+MSI+Installer+for+the+Deephaven+Excel+Add-In+2nd+gen

@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Nov 15, 2024
@kosak kosak requested a review from jcferretti November 15, 2024 02:24
@kosak kosak self-assigned this Nov 15, 2024
@kosak kosak enabled auto-merge (squash) November 20, 2024 05:15
@kosak kosak merged commit ba53da2 into deephaven:main Nov 20, 2024
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@kosak kosak deleted the kosak_advinstaller-probe branch November 25, 2024 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants