Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Close Jetty h2 streams with RST_STREAM and no error code #6401

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: Close Jetty h2 streams with RST_STREAM and no error code #6401

merged 1 commit into from
Nov 21, 2024

Conversation

niloc132
Copy link
Member

This is a Jetty-specific workaround to avoid irritating the Python gRPC client into failing calls that had already half-closed successfully.

See #6400
Fixes #5996

@niloc132 niloc132 added grpc NoDocumentationNeeded release blocker A bug/behavior that puts is below the "good enough" threshold to release. python-client jetty ReleaseNotesNeeded Release notes are needed labels Nov 19, 2024
@niloc132 niloc132 added this to the 0.37.0 milestone Nov 19, 2024
@niloc132 niloc132 merged commit 6ada0cb into deephaven:main Nov 21, 2024
30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nbauernfeind nbauernfeind nbauernfeind approved these changes

Assignees
No one assigned
Labels
grpc jetty NoDocumentationNeeded python-client release blocker A bug/behavior that puts is below the "good enough" threshold to release. ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
0.37.0
Development

Successfully merging this pull request may close these issues.

pydeephaven clients can get a RST_STREAM with CANCELLED error in some cases
2 participants
@niloc132 @nbauernfeind