perf: DH-18300: Improve DataIndex performance. #6585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpwright
changed the title
cpwright
force-pushed
the
nightly/cpw/DH-18300-main
branch
3 times, most recently
from
e92b0ee to
b468cb1
Compare
DataIndex, particularly when used for where() filters had missing parallelization opportunities; and would read more data than strictly necessary to satisfy the filter. Statistics have been added to various operations, the existing Value class was not thread safe. The internal state has been updated to use volatiles and AtomicLongFieldUpdaters. The following Configuration properties have been added: - AbstractColumnSource.usePartialDataIndex - AbstractColumnSource.useParallelIndexBuild - QueryTable.useDataIndexForAggregation - MergedDataIndex.useParallelLazyFetch
cpwright
force-pushed
the
nightly/cpw/DH-18300-main
branch
from
f86e402 to
a15b998
Compare
rcaudy
reviewed
Jan 22, 2025
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/regioned/MergedDataIndex.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/regioned/MergedDataIndex.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/AbstractColumnSource.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/AbstractColumnSource.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/AbstractColumnSource.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jan 22, 2025
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/regioned/MergedDataIndex.java
Outdated
Show resolved
Hide resolved
…s in other parts of the code.
rcaudy
reviewed
Jan 23, 2025
engine/api/src/main/java/io/deephaven/engine/table/BasicDataIndex.java
Outdated
Show resolved
Hide resolved
engine/api/src/main/java/io/deephaven/engine/table/DataIndex.java
Outdated
Show resolved
Hide resolved
engine/api/src/main/java/io/deephaven/engine/table/DataIndexOptions.java
Outdated
Show resolved
Hide resolved
engine/api/src/main/java/io/deephaven/engine/table/DataIndexOptions.java
Outdated
Show resolved
Hide resolved
Base/src/main/java/io/deephaven/base/stats/ThreadSafeValue.java
Outdated
Show resolved
Hide resolved
…dex.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
…tions.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
…tions.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
approved these changes
Jan 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataIndex, particularly when used for where() filters had missing parallelization opportunities; and would read more data than strictly necessary to satisfy the filter.