fix: Make the TDS size-sub-failure test more deterministic #6588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
NoDocumentationNeeded
NoReleaseNotesNeeded
jmao-denver
requested review from
chipkent,
rcaudy and
cpwright
as code owners
rcaudy
reviewed
Jan 22, 2025
Comment on lines
+363
to
+370
| table.coalesce() | ||
| # wait for the size subscription failure callback to be called for 5 seconds | ||
| for _ in range(50): | ||
| time.sleep(0.1) | ||
| if backend.is_size_sub_failure_cb_called: | ||
| break | ||
| else: | ||
| self.fail("size subscription failure callback was not called in 5s") |
There was a problem hiding this comment.
This is probably better than what you had, although I really don't like seeing this kind of sleep loop; does Python not have condition variables?
| with self.assertRaises(Exception) as cm: | ||
| # failure_cb will be called in the background thread after 2 PUG cycles, 3 seconds timeout should be enough | ||
| self.wait_ticking_table_update(table, 600, 3) | ||
| self.wait_ticking_table_update(table, 600, 1) |
There was a problem hiding this comment.
I suspect you need 2 seconds (2 cycles) to be safe if you're using a real PeriodicUpdateGraph with a 1 second interval. The failure is buffered after the roots are processed on one cycle, it won't be delivered until the next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have manually run the Nightly check 3 times and the fix seems to have worked.