Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui.table Single-click (on_row_press) #320

Closed
Tracked by #77
mofojed opened this issue Feb 28, 2024 · 1 comment
Closed
Tracked by #77

ui.table Single-click (on_row_press) #320

mofojed opened this issue Feb 28, 2024 · 1 comment
Assignees
@mofojed

Comments

@mofojed
Copy link
Member

mofojed commented Feb 28, 2024

No description provided.

@mofojed mofojed mentioned this issue Feb 28, 2024
Open
19 tasks
@mofojed mofojed self-assigned this Mar 5, 2024
mofojed added a commit to mofojed/web-client-ui that referenced this issue Mar 7, 2024
@mofojed
feat: Add support to pass in mouseHandlers into IrisGrid
959358f 
- Move the doubleClick behaviour from IrisGridDataSelectMouseHandler into GridSelectionMouseHandler, so it's baked into Grid itself (double-clicking a grid in the styleguide was exhibiting erroneous behaviour)
- Allow passing in mouseHandlers to IrisGrid. Will be necessary to support deephaven/deephaven-plugins#320
- Tested using my branch for on_row_press support on deephaven.ui
- Verified Linker still worked as expected
@mofojed mofojed mentioned this issue Mar 7, 2024
Merged
mofojed added a commit to deephaven/web-client-ui that referenced this issue Mar 8, 2024
@mofojed
feat: Add support to pass in mouseHandlers into IrisGrid (#1857)
acf32a6 
- Move the doubleClick behaviour from IrisGridDataSelectMouseHandler
into GridSelectionMouseHandler, so it's baked into Grid itself
(double-clicking a grid in the styleguide was exhibiting erroneous
behaviour)
- Allow passing in mouseHandlers to IrisGrid. Will be necessary to
support deephaven/deephaven-plugins#320
- Tested using my branch for `on_row_press` support on deephaven.ui:
deephaven/deephaven-plugins#346
- Verified Linker still worked as expected
@mofojed
Copy link
Member Author

mofojed commented Mar 11, 2024

Fixed with #346

@mofojed mofojed closed this as completed Mar 11, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mofojed mofojed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mofojed