Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish JS packages action does not seem to be working #617

Closed
mofojed opened this issue Jul 10, 2024 · 2 comments · Fixed by #637
Closed

Publish JS packages action does not seem to be working #617

mofojed opened this issue Jul 10, 2024 · 2 comments · Fixed by #637
Assignees
Labels
bug Something isn't working

Comments

@mofojed
Copy link
Member

mofojed commented Jul 10, 2024

For some reason the Publish JS Packages action is failing: https://github.com/deephaven/deephaven-plugins/actions/runs/9863612383

Found 1 package to publish:
 - @deephaven/js-plugin-ui => 0.17.0

lerna info auto-confirmed 
lerna info publish Publishing packages to npm...
lerna ERR! E404 Not found
Error: Process completed with exit code 1.

Also, after manually publishing, the README.md was not getting published with the package:
image
image

@mofojed mofojed added bug Something isn't working triage labels Jul 10, 2024
@mofojed mofojed self-assigned this Jul 10, 2024
@mofojed mofojed removed the triage label Jul 10, 2024
@mofojed
Copy link
Member Author

mofojed commented Jul 10, 2024

Only thing I can think of is a bad cache: lerna/lerna#3812 (comment)
The publish action is the same as the web-client-ui action, except the deephaven-plugins one specifies a cache. I've manually published the packages that were pending, but after next update if there's still an issue publishing packages I will wipe the cache and try it again. https://cli.github.com/manual/gh_cache_delete

@mofojed
Copy link
Member Author

mofojed commented Jul 17, 2024

I tried deleting the cache, and it still seems to be failing: https://github.com/deephaven/deephaven-plugins/actions/runs/9965318988/job/27537059254
The last successful run was: https://github.com/deephaven/deephaven-plugins/actions/runs/9616536886/job/26526275763
There have been no changes to the GitHub workflow since then.
Next will try updating to lerna v7, adding provenance for packages, updating GitHub actions that have newer versions. Maybe that will help. deephaven/web-client-ui#1417

mofojed added a commit to mofojed/deephaven-plugins that referenced this issue Jul 17, 2024
- Maybe this will fix why it's not currently publishing
- Maybe fixes deephaven#617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant