ci: Cleanup and enforce types check

.github/workflows/test-js-packages.yml

@@ -55,10 +55,14 @@ jobs:
         if: steps.restore-node-modules.outputs.cache-hit != 'true'
         run: npm ci --no-audit
 
+      - name: Build and type check
+        run: npm run build
+
       # Run all tests for all the packages
       # Caching with the absolute path b/c Jest will make a folder in each project
       # Then there's caches in all plugin folders
       - name: Run Tests
+        if: always() # Can still run jest tests even if the build/types fail
         run: npm run test:ci
 
       - name: Always cache node modules

package.json

@@ -8,8 +8,10 @@
   "scripts": {
     "docker": "docker compose up deephaven-plugins --build",
     "start": "run-p \"start:packages -- {@}\" serve:plugins --",
-    "build": "lerna run build --stream",
-    "watch:types": "tsc -p . --watch --emitDeclarationOnly false --noEmit",
+    "build": "run-s types build:packages",
+    "build:packages": "lerna run build --stream",
+    "types": "tsc",
+    "watch:types": "tsc --watch",
     "serve:plugins": "vite",
     "start:packages": "lerna run start --stream",
     "test": "jest --watch --changedSince origin/main",

plugins/plotly-express/src/js/src/PlotlyExpressChartModel.ts

@@ -48,7 +48,7 @@
   ) {
     super(dh);
 
-    this.widget = widget;
+    this.widget = 4;
     this.refetch = refetch;
     this.chartUtils = new ChartUtils(dh);
 

tsconfig.json

@@ -1,5 +1,9 @@
 {
   "extends": "@deephaven/tsconfig",
+  "compilerOptions": {
+    "emitDeclarationOnly": false,
+    "noEmit": true
+  },
   "include": [
     "plugins/**/**.ts",
     "plugins/**/**.tsx",