refactor: Cleanup component mappings and utils (python side) #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
commented
Jun 6, 2024
| SPECTRUM_ELEMENT_TYPE_PREFIX | ||
| ) | ||
| name.startsWith(SPECTRUM_ELEMENT_TYPE_PREFIX) && | ||
| name.substring(SPECTRUM_ELEMENT_TYPE_PREFIX.length) in |
There was a problem hiding this comment.
Added this check since the components are no longer differentiated by .spectrum namespace. All of this code will get removed in next PR anyway.
bmingles
changed the title
mofojed
requested changes
Jun 7, 2024
|
|
||
|
|
||
| def spectrum_element(name: str, /, *children: Any, **props: Any) -> BaseElement: | ||
| def base_element(name: str, /, *children: Any, **props: Any) -> BaseElement: |
There was a problem hiding this comment.
I'd probably just call this component_element and then have this used by all the other components as well (action_group, action_menu, list_view, etc) that are defining the full type currently.
|
|
||
| function RadioGroup({ | ||
| onFocus: serializedOnFocus, | ||
| onBlur: serializedOnBlur, | ||
| orientation: orientationMaybeUppercase, |
There was a problem hiding this comment.
What are we doing this for? I think should be part of a separate PR if this is something we want to handle.
There was a problem hiding this comment.
It's for consistency with other components + docs where most of our string enumerations are uppercase. I just missed it on radio PR and slipped it in. Doesn't have to be in this PR
tests/ui.spec.ts-snapshots/UI-all-components-render-1-chromium-linux.png
Outdated
Show resolved
Hide resolved
|
I addressed review comments. Split out #536 to separate the RadioGroup orientation prop |
bmingles
force-pushed
the
425-cleanup-component-mappings
branch
from
d4088a8 to
a7ee2fe
Compare
mofojed
approved these changes
Jun 13, 2024
mofojed
added a commit
to mofojed/deephaven-plugins
that referenced
this pull request
Jun 13, 2024
…eephaven#523)" This reverts commit 195f334.
mofojed
added a commit
that referenced
this pull request
Jun 13, 2024
- Need to revert some changes that require a newer version of @deephaven/components so that we can publish a version for Enterprise V+ - Will publish and then add these back to main - **Revert "refactor: Cleanup component mappings and utils (python side) (#523)"** - **Revert "feat: Make RadioGroup orientation prop case insensitive (#536)"** - **Revert "feat: ui.checkbox, ui.button, ui.button_group, ui.radio, ui.radio_group, ui.icon (#512)"** - **Revert "chore: Update DH packages to ^0.81.1 jsapi-types to ^1.0.0-dev0.34.3 (#511)"** - Tested with a V+ branch on Enterprise and v0.78 of `@deephaven` packages
mofojed
added a commit
that referenced
this pull request
Jun 13, 2024
…78 (#550)" (#551) - This reverts commit 27414e1. - Adds back the following reverted changes: - **Revert "refactor: Cleanup component mappings and utils (python side) (#523)"** - **Revert "feat: Make RadioGroup orientation prop case insensitive (#536)"** - **Revert "feat: ui.checkbox, ui.button, ui.button_group, ui.radio, ui.radio_group, ui.icon (#512)"** - **Revert "chore: Update DH packages to ^0.81.1 jsapi-types to ^1.0.0-dev0.34.3 (#511)"**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of 2 PRs to simplify our DH UI component mappings since we no longer have the Spectrum dependency. This one addresses the python modules + minimal re-mapping in the JS to make it still work. The next one will cleanup the .js side more holistically.
resolves #425