-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: density heatmap #598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put this up for review but going to add one more arg
|
mofojed
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other density_heatmap
functions I tested with, adapted from https://plotly.com/python/2D-Histogram/#density-heatmaps-with-plotly-express:
import deephaven.plot.express as dx
tips = dx.data.tips()
f_tips = dx.density_heatmap(tips, x="total_bill", y="tip")
f_tips2 = dx.density_heatmap(tips, x="total_bill", y="tip", nbinsx=20, nbinsy=20, color_continuous_scale="Inferno")
iris = dx.data.iris()
f_iris = dx.density_heatmap(iris, x="petal_length", y="petal_width", z="sepal_length", histfunc="avg")
plugins/plotly-express/src/deephaven/plot/express/deephaven_figure/custom_draw.py
Outdated
Show resolved
Hide resolved
plugins/plotly-express/src/deephaven/plot/express/deephaven_figure/custom_draw.py
Outdated
Show resolved
Hide resolved
plugins/plotly-express/src/deephaven/plot/express/plots/heatmap.py
Outdated
Show resolved
Hide resolved
mofojed
requested changes
Jul 16, 2024
plugins/plotly-express/src/deephaven/plot/express/preprocess/utilities.py
Outdated
Show resolved
Hide resolved
plugins/plotly-express/src/deephaven/plot/express/plots/heatmap.py
Outdated
Show resolved
Hide resolved
plugins/plotly-express/src/deephaven/plot/express/preprocess/utilities.py
Show resolved
Hide resolved
mofojed
approved these changes
Jul 16, 2024
jnumainville
added a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
This doesn't add every argument, but does add the core ones and trivial ones
Here is a good example of the basic ways this can be used, either with
x
,y
, andhistfunc="count"
, orx
,y
,z
, and anyhistfunc
, as well as other arguments to control the binning as, likehistogram
, how someone chooses to bin has a large impact on the visualization