build: Clean the build directory before building the wheel #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When rebuilding the wheel, it had stale files for the _js files, which was confusing and annoying - Clean the build directory so it doesn't have stale files - Remove the `package_data` flag - it's already captured by default with the `include_package_data` option: https://setuptools.pypa.io/en/latest/userguide/datafiles.html#include-package-data - Still need to run `npm run build` between builds
mattrunyon
reviewed
Jul 5, 2024
plugins/ui/setup.py
Outdated
Comment on lines
9
to
13
| # remove the build directory to ensure that the package is built from the latest js files | ||
| try: | ||
| shutil.rmtree("build") | ||
| except FileNotFoundError: | ||
| pass |
There was a problem hiding this comment.
Can we also add a block like this for dist? Around releases I will sometimes end up w/ re-using my install command from before the release that will point to a 0.15.0 build. But really I've updated to 0.16.0 in my build. However, the old wheels still exist in dist and that has caused me confusion at least once wondering why my server didn't seem to update the plugin properly
|
This should also be added to the other plugins that package JS. I wonder if it should be part of the |
- I mis-read the details, `include_package_data` is only True when configured via pyproject.toml file
jnumainville
approved these changes
Jul 12, 2024
jnumainville
added a commit
that referenced
this pull request
Jul 29, 2024
We recently merged #599 which works fine locally but appears to remove the `whl` file in our gh actions. There are other solutions we can investigate, but this is just to get ui docs built so any better solution is beyond the scope of this. It's worth noting that `plugin_builder.py` also will clean the directories up automatically and might be the better path forward for development cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run buildbetween builds