-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better deephaven ui button defaults #613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cta` and `overBackground` aren't variants
dsmmcken
commented
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea where you got cta
and overBackground
, co-pilot hallucinations?
I see now they are deprecated spectrum legacy options:
/** @deprecated */
type LegacyButtonVariant = 'cta' | 'overBackground';
dsmmcken
changed the title
fix: remove non-existent types
fix: remove non-existent button variant types
Jul 9, 2024
dsmmcken
changed the title
fix: remove non-existent button variant types
fix: remove non-existent button variant types and add button element_type
Jul 9, 2024
… no variant it doesn't get a hover states, and with no style static_color won't work without a variant and style.
dsmmcken
changed the title
fix: remove non-existent button variant types and add button element_type
feat: polish deephaven ui button defaults
Jul 9, 2024
dsmmcken
changed the title
feat: polish deephaven ui button defaults
feat: better deephaven ui button defaults
Jul 9, 2024
mofojed
requested changes
Jul 11, 2024
Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
accent
the default variant, andfill
the default style.cta
andoverBackground
variants.a
for href link buttons to work. I've made this internal and just auto set it for users if href is set.BREAKING CHANGE:
ui.button defaults changed to
variant="accent"
andstyle="fill"
. To restore previous styling, usevariant="primary"
andstyle="outline"
.