Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ui.table reverse prop #629

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

mattrunyon
Copy link
Collaborator

Fixes #607

The concern I had about reverse/sort order is that it does matter, but we only apply a post-sort reverse in the UI via the reverse action.

We do however not have that plumbed up properly in IrisGrid (we define pre-sort, but don't use it and don't properly apply the reverse pre-sort if it's specified). But it works for what we want in ui.table

from deephaven import ui
from deephaven.plot import express as dx

_stocks = dx.data.stocks()

stocks_reversed = ui.table(
    _stocks,
    reverse=True
)

@mattrunyon mattrunyon requested a review from mofojed July 15, 2024 22:47
@mattrunyon mattrunyon self-assigned this Jul 15, 2024
@mattrunyon mattrunyon merged commit e56424c into deephaven:main Jul 16, 2024
14 checks passed
@mattrunyon mattrunyon deleted the ui-table-reverse branch July 16, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui.table setting for default "reverse" option
2 participants