Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server-base is hampered by optional dependencies #71

Open
devinrsmith opened this issue Nov 9, 2023 · 1 comment
Open

server-base is hampered by optional dependencies #71

devinrsmith opened this issue Nov 9, 2023 · 1 comment
Assignees
@devinrsmith
Labels
enhancement New feature or request

Comments

@devinrsmith
Copy link
Member

The server-base image specifies some optional dependencies that deephaven-core uses for testing; this has the effect of adding constraints to server-base that deephaven-core doesn't otherwise have. For example, turbodbc has constraints that limit the version of pyarrow that can be installed (and thus, limits the versions that deephaven-core can test).

Ideally, all of the "base" image logic (and potentially even these release images) could move into deephaven-core as part of, or after, deephaven/deephaven-core#3723.
@devinrsmith devinrsmith added the enhancement New feature or request label Nov 9, 2023
@devinrsmith devinrsmith self-assigned this Nov 9, 2023
This was referenced Nov 9, 2023
Open
Open
@devinrsmith
Copy link
Member Author

This is also limiting the ease of producing alternative images; for example, to get python 3.8 working, several changes need to be made to remove these optional dependencies (turbodbc does not have 3.8 support, adbc does not have 3.8 support, etc).

devinrsmith added a commit to devinrsmith/deephaven-server-docker that referenced this issue Mar 11, 2024
@devinrsmith
Sketch out changes necessary for python 3.8 base image
f769a82 
Related to deephaven#71
@devinrsmith devinrsmith mentioned this issue Mar 11, 2024
Draft
devinrsmith added a commit to devinrsmith/deephaven-server-docker that referenced this issue Jun 17, 2024
@devinrsmith
Remove turbodbc build
4efdb04 
This is removing turbodbc, as we are not able to get the latest version to build (see deephaven#97). This effects our ability to test the latest version of numpy.

See deephaven#71 for related concerns generally about option dependencies and the restrictions they place on server-base.
@devinrsmith devinrsmith mentioned this issue Jun 17, 2024
Merged
devinrsmith added a commit that referenced this issue Jun 17, 2024
@devinrsmith
Remove turbodbc build (#98)
8543efe 
This is removing turbodbc, as we are not able to get the latest version to build (see #97). This effects our ability to test the latest version of numpy.

See #71 for related concerns generally about option dependencies and the restrictions they place on server-base.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devinrsmith devinrsmith

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devinrsmith