build: Pre-release publish vscode extension #26
Conversation
bmingles
force-pushed
the
18-prerelease-vscode-extension
branch
from
da7f46d
to
ea09fa4
Compare
There was a problem hiding this comment.
Looks good, just a weird bit around the src/jsapi.downloadDhFromServer() part. I think that was just copied/pasted, but may as well fix at the same time.
As for publishing - I'm assuming we'll get deephaven-bot to publish from the GitHub action in time with this ticket, and this is just for manually publishing right now: #28
CONTRIBUTING.md
Outdated
|
|
||
| The extension dynamically downloads and loads the DH JS API from a running DH Core server. | ||
|
|
||
| - `src/jsApi.downloadDhFromServer()` |
There was a problem hiding this comment.
Typo? Confused about this part. Seems like it was carried over from README.md, must have missed it before.
There was a problem hiding this comment.
Fixed.
And yes, #28 will deal with CI deployment presumably from deephaven-bot
CONTRIBUTING.md
Outdated
| @@ -84,5 +84,5 @@ On subsequent script runs, the session will be re-used and only steps 4 and 5 wi | |||
|
|
|||
| The extension dynamically downloads and loads the DH JS API from a running DH Core server. | |||
|
|
|||
| - `src/jsApi.downloadDhFromServer()` | |||
| At runtime, `dh-internal.js` and `dh-core.js` are downloaded from the running DH server (default http://localhost:10000). The files are saved to `out/tmp` as `.cjs` modules, and import / export are converted to cjs compatible ones. | |||
| - `src/dh/dhc.getDhc()` | |||
There was a problem hiding this comment.
I still find this confusing. Why is the function a bullet point? Why is it calling the function? It seems to break up the paragraph unnecessarily, would just remove the bullet point, have the paragraph go "...running DH Core Server. At runtime ...", then at the end maybe have a link "For implementation details, see ./src/dh/dhc.ts#getDhc" or something like that.
Extension has been published as a pre-release version to Visual Studio Marketplace
https://marketplace.visualstudio.com/items?itemName=deephaven.vscode-deephaven
We now have the following:
In this PR:
resolves #18