Skip to content

Commit

Permalink
fix: swap goto tooltips (#1860)
Browse files Browse the repository at this point in the history
- Fixes #1826 
  - Swap "Previous match" and "Next match"
  • Loading branch information
wusteven815 authored Mar 12, 2024
1 parent 52de3d1 commit 6236b47
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions packages/iris-grid/src/GotoRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ const GotoRow = forwardRef<GotoRowElement, GotoRowProps>(

<div>
<Button
tooltip="Next match"
tooltip="Previous match"
icon={vsArrowUp}
kind="ghost"
disabled={gotoValue === ''}
Expand All @@ -395,7 +395,7 @@ const GotoRow = forwardRef<GotoRowElement, GotoRowProps>(
}}
/>
<Button
tooltip="Previous match"
tooltip="Next match"
icon={vsArrowDown}
kind="ghost"
disabled={gotoValue === ''}
Expand Down
6 changes: 3 additions & 3 deletions tests/context-menu.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,13 +219,13 @@ test('go to', async ({ page }) => {
await waitForLoadingDone(page);
await expect(page.locator('.iris-grid-column')).toHaveScreenshot();

await page.locator('[aria-label="Previous match"]').first().click();
await page.locator('[aria-label="Previous match"]').first().click();
await page.locator('[aria-label="Next match"]').first().click();
await page.locator('[aria-label="Next match"]').first().click();

await waitForLoadingDone(page);
await expect(page.locator('.iris-grid-column')).toHaveScreenshot();

await page.locator('[aria-label="Next match"]').first().click();
await page.locator('[aria-label="Previous match"]').first().click();

await waitForLoadingDone(page);
await expect(page.locator('.iris-grid-column')).toHaveScreenshot();
Expand Down

0 comments on commit 6236b47

Please sign in to comment.