Aggregate Columns ignores columns selection

[dsmmcken]

Description

Steps to reproduce

Using the following table:

from deephaven import empty_table, time_table

simple_ticking = time_table("PT00:00:01").update([
        "MyString=new String(`a`+i)",
        "MyInt=new Integer(i)",
        "MyLong=new Long(i)",
        "MyDouble=new Double(i+i/10)",
        "MyFloat=new Float(i+i/10)",
        "MyBoolean=new Boolean(i%2==0)",
        "MyChar= new Character((char) ((i%26)+97))",
        "MyShort=new Short(Integer.toString(i%32767))",
        "MyByte= new java.lang.Byte(Integer.toString(i%127))"])

complex_ticking = simple_ticking.update([
        "MyBigDecimal= new java.math.BigDecimal(i+i/10)",
        "MyBigInteger= new java.math.BigInteger(Integer.toString(i))"
])                          

1. select from table options sidebar "Aggregate Columns"
2. Select sum from drop down and click add aggregation
3. From the sum button click the pencil to edit aggregations
4. De-select a number of columns

Expected results

Sum is only computed for the selected columns

Actual results

Sum is selected for all columns

Versions
Vermillion and

Engine Version: 0.26.0
Web UI Version: 0.40.4
Java Version: 17.0.7
Barrage Version: 0.5.0

[mofojed]

Seems to be broken in Silverheels as well. The issue isn't evident if you pass in a different type of operation (e.g. Max) instead of Sum, but the aggregation is actually still happening on the server. The defaultOperation being set is SUM: https://github.com/deephaven/deephaven-core/blob/ede9c3977a86f4558c8495a036d3dc487e68e475/web/client-api/src/main/java/io/deephaven/web/client/api/JsTotalsTableConfig.java#L80

UI can't set that to SKIP because that operation is deprecated (it throws an error if we try to use it): https://github.com/deephaven/deephaven-core/blob/ede9c3977a86f4558c8495a036d3dc487e68e475/web/client-api/src/main/java/io/deephaven/web/client/api/tree/enums/JsAggregationOperation.java#L34

UI could set FIRST or some other inexpensive operation instead, but we'll have the same issue if you choose the FIRST aggregation when you only want FIRST on one.

@niloc132 how are we supposed to use this? Seems like having the defaultOperation = SUM isn't really what we want in general?

[vbabich]

@niloc132 will add the SKIP operation and the UI will need to set that as a default.

[niloc132]

Is there a dhc issue for this? I'm not finding one...

[mofojed]

@niloc132 Would need to split off one for core

[mofojed]

@niloc132 finally created one for core: deephaven/deephaven-core#4182