Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat files as opaque strings to support different file systems #2046

Open
mofojed opened this issue May 30, 2024 · 1 comment · May be fixed by #2118
Open

Treat files as opaque strings to support different file systems #2046

mofojed opened this issue May 30, 2024 · 1 comment · May be fixed by #2118
Assignees
@mofojed
Labels
enhancement New feature or request
Milestone
July 2024

Comments

@mofojed
Copy link
Member

mofojed commented May 30, 2024 •
edited

Related to deephaven/deephaven-core#5068 and deephaven/deephaven-core#5532

Currently Web UI assumes file paths all use a / as a delimiter and start with a slash. On native Windows and in some other situations (such as S3 buckets) that may not necessarily be the case. Instead of assuming there is a / delimiter, we should be treating the file path as an opaque string, and getting the delimiter from the JS API.
@mofojed mofojed added enhancement New feature or request triage Issue requires triage labels May 30, 2024
@mofojed mofojed added this to the June 2024 milestone Jun 3, 2024
@mofojed mofojed removed the triage Issue requires triage label Jun 3, 2024
@mofojed
Copy link
Member Author

mofojed commented Jun 10, 2024

Core side merged initial PR: deephaven/deephaven-core#5532
Should be able to get the file delimiter via the file.separator config path.

@mofojed mofojed self-assigned this Jun 24, 2024
@mofojed mofojed linked a pull request Jun 28, 2024 that will close this issue
Open
@vbabich vbabich modified the milestones: June 2024, July 2024 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mofojed mofojed

Labels
enhancement New feature or request
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

feat: Read file separator from server config mofojed/web-client-ui
2 participants
@vbabich @mofojed