StorageService paths should be treated as opaque strings, part 1 #5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
NoDocumentationNeeded
ReleaseNotesNeeded
niloc132
requested review from
devinrsmith,
nbauernfeind and
rcaudy
as code owners
mofojed
approved these changes
Jun 2, 2024
nbauernfeind
approved these changes
Jun 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to fix #5068 by treating StorageService paths as opaque strings, by telling the client the canonical path when performing a directory listing. This enables clients to solve for the file's own name.
In order to maintain compatibility with the current web-client-ui, all paths must still begin with "/" - the final patch for this issue will remove that limitation.
Also includes the file separator, notebook directory, and layouts directory as configuration details for clients to read.
Partial #5068