Skip to content

Commit

Permalink
StorageService paths should be treated as opaque strings, part 1 (#5532)
Browse files Browse the repository at this point in the history
First step to fix #5068 by treating StorageService paths as opaque
strings, by telling the client the canonical path when performing a
directory listing. This enables clients to solve for the file's own
name.

In order to maintain compatibility with the current web-client-ui, all
paths must still begin with "/" - the final patch for this issue will
remove that limitation.

Also includes the file separator, notebook directory, and layouts
directory as configuration details for clients to read.

Partial #5068
  • Loading branch information
niloc132 authored Jun 3, 2024
1 parent 515fd8e commit 2da295f
Show file tree
Hide file tree
Showing 14 changed files with 500 additions and 186 deletions.
141 changes: 89 additions & 52 deletions cpp-client/deephaven/dhclient/proto/deephaven/proto/storage.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

75 changes: 73 additions & 2 deletions cpp-client/deephaven/dhclient/proto/deephaven/proto/storage.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2da295f

Please sign in to comment.