Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DH-16336: usePickerWithSelectedValues - boolean flags should be calculated based on trimmed search text #1750

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Jan 26, 2024

Supports DH-16336:

  • Added an isDebouncing prop to useDebouncedValue
  • Added support for search text trimming to usePickerWithSelectedValues
  • Introduced a validation delay to account for viewport filtering to improve UX and avoid flicker of validation message

resolves #1747

Note that there's not any place in DHC that uses the usePickerWithSelectedValues hook yet. I've been testing locally as part of DH-16336.

BREAKING CHANGE: usePickerWithSelectedValues now takes an object as an argument instead of positional args

@bmingles bmingles marked this pull request as draft January 26, 2024 00:15
@bmingles bmingles force-pushed the 1747-usePickerWithSelectedValues branch from a1b2be7 to 7d26a76 Compare January 26, 2024 00:47
@bmingles bmingles force-pushed the 1747-usePickerWithSelectedValues branch from 7d26a76 to ce652c2 Compare January 26, 2024 01:28
@bmingles bmingles marked this pull request as ready for review January 26, 2024 16:42
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45fa929) 46.04% compared to head (339c612) 46.07%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1750      +/-   ##
==========================================
+ Coverage   46.04%   46.07%   +0.03%     
==========================================
  Files         621      623       +2     
  Lines       37454    37531      +77     
  Branches     9413     9437      +24     
==========================================
+ Hits        17244    17293      +49     
- Misses      20156    20184      +28     
  Partials       54       54              
Flag Coverage Δ
unit 46.07% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles requested a review from mofojed January 26, 2024 17:02
@bmingles bmingles merged commit 228f34d into deephaven:main Jan 31, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@bmingles bmingles deleted the 1747-usePickerWithSelectedValues branch January 31, 2024 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: DH-16336: usePickerWithSelectedValues - boolean flags should be calculated based on trimmed search text
2 participants