feat: Update panels from field change events #1925
Conversation
| const widgetContentItem = LayoutUtils.getContentItemInRoot( | ||
| layout.root, | ||
| { | ||
| title: toUpdate.title, | ||
| } | ||
| ); |
There was a problem hiding this comment.
We shouldn't be using the title here. The title changes when we clone panels and when we rename panels.
We should instead be matching by panelId (which we should already know if the panel was opened by AppMainContainer) or by the metadata. Problem is as you've identified below, ConsolePanel is doing a similar thing for panels that it has opened, so you can get conflicts.
Perhaps the panel/component itself should be listening for field updates, and update the widget if the underlying field changes (based somewhat on Raffi's comment that he would always want/expect the widget to reflect the currently named widget, indicating our behaviour when opening a panel and it not updating is incorrect).
There was a problem hiding this comment.
I like the idea of the panel listening for changes and updating itself. I'll look into that.
There was a problem hiding this comment.
@bmingles Are we still actively making code changes here? if not, we could probably close this PR since it has been open for a couple of months now as a draft?
|
Closing as we'll probably need a different approach and this has been de-prioritized since vscode extension now uses embed widget. |
resolves #1924