Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update @vscode/codicons to 0.36 #2010

Merged
merged 2 commits into from
May 15, 2024
Merged

feat: update @vscode/codicons to 0.36 #2010

merged 2 commits into from
May 15, 2024

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented May 13, 2024

Exposes several new icons. Added ability to exclude icons from vscode.

Exclude repo-fetch due to it not being convertible to a single shape path with svgo.

Rounded rects don't convert with https://github.com/svg/svgo/blob/main/plugins/convertShapeToPath.js

Exposes several new icons. Exclude repo-fetch due to it not being convertible to a single shape path with svgo.

Rounded rects don't convert with https://github.com/svg/svgo/blob/main/plugins/convertShapeToPath.js
@dsmmcken dsmmcken requested a review from mofojed May 13, 2024 21:16
@dsmmcken dsmmcken changed the title chore: update @vscode/codicons to 0.36 feat: update @vscode/codicons to 0.36 May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.36%. Comparing base (7d59d09) to head (b04a3ad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2010   +/-   ##
=======================================
  Coverage   46.36%   46.36%           
=======================================
  Files         668      668           
  Lines       38695    38695           
  Branches     9799     9799           
=======================================
  Hits        17940    17940           
  Misses      20702    20702           
  Partials       53       53           
Flag Coverage Δ
unit 46.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/icons/scripts/build.js Outdated Show resolved Hide resolved
@dsmmcken dsmmcken requested a review from mofojed May 14, 2024 14:25
@dsmmcken dsmmcken enabled auto-merge (squash) May 14, 2024 17:34
@dsmmcken dsmmcken merged commit 3a6a439 into main May 15, 2024
10 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_icons_36 branch May 15, 2024 14:57
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants