Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-17242: Partition Table Pickers not partitioning table properly #2096

Conversation

AkshatJawne
Copy link
Contributor

@AkshatJawne AkshatJawne commented Jun 21, 2024

Resolves #2066

This PR is solely to solve the bugs of the partition table; first that the widget was not appearing, and once appearing, the partition selectors not working properly. The PartitionedTable design changes and additional functionality specified in #2079 to be brought up here #2110

@AkshatJawne AkshatJawne self-assigned this Jun 21, 2024
@mofojed mofojed removed their request for review June 25, 2024 18:03
@mattrunyon
Copy link
Collaborator

I think your e2e tests might be failing due to a core change. Looks like it's failing to apply date filters

@AkshatJawne
Copy link
Contributor Author

Hmm interesting, I guess I will try and pull the newest version of main?

@AkshatJawne
Copy link
Contributor Author

I do see that is due to a screenshot, but I thought that it may be due to the change in the Partition Table label that I made here

@AkshatJawne AkshatJawne changed the title fix: Partition Table not rendering with additional non key columns fix: Partition Table Pickers not partitioning table properly Jun 26, 2024
Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so looks like IrisGridPartitionSelector.scss needs some modification. There's still the divider line to the left of the buttons on the left side of this image
image

Looks like you need to change .partition-button-group for border-style to border-right-style: solid . And then padding to padding-right: $spacer-2

@mattrunyon
Copy link
Collaborator

Also, if this is the PR that fixes the linked ticket (there are 2 and I think this is the real one as the other PR just includes these commits right now) then change the title to fix: DH-17242: Partition.... That way when we update the web package versions in enterprise, we see the Jira ticket in the changelog and know to update its status

@AkshatJawne AkshatJawne changed the title fix: Partition Table Pickers not partitioning table properly fix: DH-17242: Partition Table Pickers not partitioning table properly Jun 27, 2024
@AkshatJawne
Copy link
Contributor Author

Will hold off on merging until we can add filter prop to the Picker component, to avoid having to set the viewport on each render to 0,50 -- @bmingles mentioned that will have to wait for #2077 to merge before making these changes.

Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to request changes so it doesn't get accidentally merged

@AkshatJawne
Copy link
Contributor Author

Closing this PR given that we are no longer opting to manually set the viewport to 0,50 -- and we ultimately did not add a filter prop to Picker, but rather changed how the options are populated in the pickers.

Refer to #2110 for all details and updated changes

@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants