-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DH-17242: Partition Table Pickers not partitioning table properly #2096
fix: DH-17242: Partition Table Pickers not partitioning table properly #2096
Conversation
I think your e2e tests might be failing due to a core change. Looks like it's failing to apply date filters |
Hmm interesting, I guess I will try and pull the newest version of main? |
I do see that is due to a screenshot, but I thought that it may be due to the change in the Partition Table label that I made here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so looks like IrisGridPartitionSelector.scss
needs some modification. There's still the divider line to the left of the buttons on the left side of this image
Looks like you need to change .partition-button-group
for border-style
to border-right-style: solid
. And then padding
to padding-right: $spacer-2
Also, if this is the PR that fixes the linked ticket (there are 2 and I think this is the real one as the other PR just includes these commits right now) then change the title to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to request changes so it doesn't get accidentally merged
Closing this PR given that we are no longer opting to manually set the viewport to 0,50 -- and we ultimately did not add a filter prop to Picker, but rather changed how the options are populated in the pickers. Refer to #2110 for all details and updated changes |
Resolves #2066
This PR is solely to solve the bugs of the partition table; first that the widget was not appearing, and once appearing, the partition selectors not working properly. The
PartitionedTable
design changes and additional functionality specified in #2079 to be brought up here #2110