-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add functions for PanelEvent.OPEN #2144
Merged
mofojed
merged 4 commits into
deephaven:feature/core-plugins-refactor
from
mofojed:feature/core-plugins-refactor
Jul 16, 2024
Merged
feat: Add functions for PanelEvent.OPEN #2144
mofojed
merged 4 commits into
deephaven:feature/core-plugins-refactor
from
mofojed:feature/core-plugins-refactor
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Jul 15, 2024
- Instead of using PanelEvent.OPEN directly and not getting any type safety, add functions for emitting, listening, and a hook to enforce type safety
- Add xcomponents to the styleguide
- Instead of using PanelEvent.OPEN directly and not getting any type safety, add functions for emitting, listening, and a hook to enforce type safety
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/core-plugins-refactor #2144 +/- ##
=================================================================
- Coverage 46.71% 46.71% -0.01%
=================================================================
Files 689 690 +1
Lines 38521 38526 +5
Branches 9814 9727 -87
=================================================================
+ Hits 17996 17997 +1
- Misses 20473 20477 +4
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattrunyon
requested changes
Jul 15, 2024
- Clarify some of the comments - Add more unit tests
mattrunyon
approved these changes
Jul 16, 2024
cbd2b1e
into
deephaven:feature/core-plugins-refactor
11 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.