[doc] custom output formatter schema #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
approved these changes
Jun 4, 2024
siddvenk
reviewed
Jun 4, 2024
| +RequestInput input | ||
| } | ||
| class TextGenerationOutput{ | ||
| +map sequences |
|
|
||
| class RequestInput{ | ||
| +int request_id | ||
| +dict parameters |
There was a problem hiding this comment.
we used map previously, and dict here. Let's keep it consistent (or maybe i'm not understanding the difference between the two).
If they are the same, should we say what the mapping is? (from what to what)
| from djl_python.output_formatter import TextGenerationOutput | ||
| import json | ||
|
|
||
| def custom_output_formatter(request_output: TextGenerationOutput): |
There was a problem hiding this comment.
nit: let's add the return type here -> str to keep it consistent with the method signature we explain at the top
|
|
||
| """ | ||
| best_sequence = request_output.sequences[request_output.best_sequence_index] | ||
| next_token, first_token, last_token = best_sequence.get_next_token() |
There was a problem hiding this comment.
out of scope here, but it seems confusing that get_next_token returns 3 token values? i'll connect with you later to understand this more
There was a problem hiding this comment.
yes it might be more clear if its next_token, is_first_token, is_last_token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about