Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove validating quantization in properties_manager.py #2067

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

sindhuvahinis
Copy link
Contributor

@sindhuvahinis sindhuvahinis commented Jun 14, 2024

Description

Test case passed : https://github.com/deepjavalibrary/djl-serving/actions/runs/9521520715/job/26249192465

We dont need validate quantization in properties_manager.py. We already do validate in HuggingFaceProperties which is called before quantization.

@sindhuvahinis sindhuvahinis requested review from zachgk, frankfliu and a team as code owners June 14, 2024 18:35
@sindhuvahinis sindhuvahinis changed the title [fix] add static_int8 to supported quantization methods [fix] remove validating quantization in properties_manager.py Jun 14, 2024
@sindhuvahinis sindhuvahinis merged commit 8014efc into deepjavalibrary:master Jun 14, 2024
8 checks passed
@sindhuvahinis sindhuvahinis deleted the fix branch June 20, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants