Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] refactor rolling batch inference method #2090

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[python] refactor rolling batch inference method #2090

merged 1 commit into from
Jun 20, 2024

Conversation

sindhuvahinis
Copy link
Contributor

Description

  • Our handlers calls the rolling_batch.inference and constructs the output, but our handlers share the same code, so there are some code duplication
  • So extracted the duplicated code to utils.py.
  • In huggingface.py, inference method is too long, so modularized them.
  • There are some further more refactor will be done next week, which will clean up these method signatures further better.

@sindhuvahinis sindhuvahinis requested review from zachgk, frankfliu and a team as code owners June 19, 2024 21:44
@sindhuvahinis sindhuvahinis merged commit 44f9508 into deepjavalibrary:master Jun 20, 2024
9 checks passed
@sindhuvahinis sindhuvahinis deleted the rb_ref branch June 20, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgk zachgk zachgk approved these changes

@frankfliu frankfliu Awaiting requested review from frankfliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sindhuvahinis @zachgk