Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Neuron] Fix Neuron compilation logging #2095

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

a-ys
Copy link
Contributor

@a-ys a-ys commented Jun 21, 2024

Description

Fixes Neuron compilation logging. Example logs that were missing:

2024-02-21 01:04:37.000772: 246 INFO ||NEURON_CC_WRAPPER||: Using a cached neff at /opt/ml/compilation/cache/neuronxcc-2.12.54.0+f631c2365/MODULE_b135f12bed698159448c+ede6753c/model.neff. Exiting with a successfully compiled graph.
2024-02-21 01:04:37.000823: 247 INFO ||NEURON_CACHE||: Compile cache path: /opt/ml/compilation/cache
2024-02-21 01:04:37.000875: 247 INFO ||NEURON_CC_WRAPPER||: Using a cached neff at /opt/ml/compilation/cache/neuronxcc-2.12.54.0+f631c2365/MODULE_b702d7ddf38e1da4abf8+ede6753c/model.neff. Exiting with a successfully compiled graph.
2024-02-21 01:04:38.000380: 248 INFO ||NEURON_CC_WRAPPER||: Using a cached neff at /opt/ml/compilation/cache/neuronxcc-2.12.54.0+f631c2365/MODULE_02b140725c88b5ccd391+ede6753c/model.neff. Exiting with a successfully compiled graph.
...

Caused by additional vLLM dependency introduced in 0.28.0 container. The logger in vLLM (defined here) does not specify disable_existing_loggers=False. We should fix in upstream vLLM, but in the meantime, this PR manually enables the relevant loggers to fix the issue.

@a-ys a-ys requested review from zachgk, frankfliu and a team as code owners June 21, 2024 19:47
@tosterberg tosterberg merged commit ac4acb8 into deepjavalibrary:master Jun 21, 2024
9 checks passed
tosterberg pushed a commit to tosterberg/djl-serving that referenced this pull request Jul 18, 2024
tosterberg added a commit that referenced this pull request Jul 18, 2024
Co-authored-by: Andrew Song <40076917+a-ys@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants