Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Integration tests through pytest #2109

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[CI] Integration tests through pytest #2109

merged 1 commit into from
Jul 3, 2024

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Jun 26, 2024

This combines the older integration test suite into the new pytest one. It uses the original integration action rather than the llm_integration one.

Sample run: https://github.com/deepjavalibrary/djl-serving/actions/runs/9671865360

@zachgk zachgk requested review from frankfliu and a team as code owners June 26, 2024 01:20
outputs:
gpu_instance_id: ${{ steps.create_gpu.outputs.action_gpu_instance_id }}
gpu_instance_id_1: ${{ steps.create_gpu.outputs.action_g6_instance_id }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you want to merge all tests? This will make a lot of idle instances and make the pipeline hard to get to green

This combines the older integration test suite into the new pytest one. It uses
the original integration action rather than the llm_integration one.
@tosterberg
Copy link
Contributor

With regards to Qing's comment - I do agree that this will be harder to pass, but not significantly so when compared to the large model integration script that we are folding in here. Moving to a single script and then parting out to create specific "golden" passing workflows makes sense to me.

Aside - this will remove the Large Model Inference from actions, so we will need to do a follow up CLI trigger on a release branch so that the action is still manually executable for release branches. I will do this post merge.

@zachgk zachgk merged commit 1482ace into master Jul 3, 2024
9 checks passed
@zachgk zachgk deleted the tests-integ branch July 3, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants