[secure-mode] Add properties allowlist validation #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer a denylist instead of an allowlist With this, new configs are not allowed by default (maybe that's the desired behavior), but I feel like there are going to be new configs added that should be allowed more often than new configs added that are disallowed. |
ethnzhng
force-pushed
the
secure-mode-patch
branch
from
bb041b9 to
4f53236
Compare
siddvenk
reviewed
Jun 28, 2024
plugins/secure-mode/src/main/java/ai/djl/serving/plugins/securemode/SecureModeUtils.java
Outdated
Show resolved
Hide resolved
frankfliu
reviewed
Jun 28, 2024
plugins/secure-mode/src/main/java/ai/djl/serving/plugins/securemode/SecureModeAllowList.java
Outdated
Show resolved
Hide resolved
plugins/secure-mode/src/main/java/ai/djl/serving/plugins/securemode/SecureModeAllowList.java
Show resolved
Hide resolved
ethnzhng
force-pushed
the
secure-mode-patch
branch
from
b9dc22f to
e1c9644
Compare
ethnzhng
force-pushed
the
secure-mode-patch
branch
from
e1c9644 to
d019e01
Compare
lanking520
approved these changes
Jun 28, 2024
frankfliu
approved these changes
Jun 28, 2024
frankfliu
pushed a commit
to frankfliu/djl-serving
that referenced
this pull request
Jun 28, 2024
frankfliu
added a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.