Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] support multimodal models openai api in vllm #2147

Merged
merged 3 commits into from
Jul 10, 2024
Merged

[python] support multimodal models openai api in vllm #2147

merged 3 commits into from
Jul 10, 2024

Conversation

sindhuvahinis
Copy link
Contributor

@sindhuvahinis sindhuvahinis commented Jul 6, 2024 •
edited
Loading

Description

Waiting for vllm upgrade 0.5.1 in our lmi.Dockerfile

This needs vLLM 0.5.1 version, but our container is not updated yet.

Testing:

  1. Manually tested in my EC2 with vllm 0.5.0.post1 installed
  2. Added integration test for llava-chat
  3. Added unit test case for parsing the chat template with vision

@sindhuvahinis sindhuvahinis requested review from zachgk, frankfliu and a team as code owners July 6, 2024 00:19
@sindhuvahinis sindhuvahinis requested a review from siddvenk July 6, 2024 00:19
@sindhuvahinis
Copy link
Contributor Author

Waiting for vllm upgrade 0.5.1 in our lmi.Dockerfile

@sindhuvahinis sindhuvahinis merged commit 0ff540b into deepjavalibrary:master Jul 10, 2024
9 checks passed
@sindhuvahinis sindhuvahinis deleted the llava branch July 10, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankfliu frankfliu frankfliu approved these changes

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@siddvenk siddvenk Awaiting requested review from siddvenk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sindhuvahinis @lanking520 @frankfliu