Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lmi] Upgrade lmi dockerfile for 0.29.0 release #2156

Merged
merged 1 commit into from
Jul 13, 2024
Merged

[lmi] Upgrade lmi dockerfile for 0.29.0 release #2156

merged 1 commit into from
Jul 13, 2024

Conversation

maaquib
Copy link
Contributor

@maaquib maaquib commented Jul 10, 2024 •
edited
Loading

Description

CI test: https://github.com/deepjavalibrary/djl-serving/actions/runs/9916087551

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

lanking520
lanking520 reviewed Jul 10, 2024
View reviewed changes
serving/docker/lmi.Dockerfile Show resolved Hide resolved
serving/docker/lmi.Dockerfile Outdated Show resolved Hide resolved
lanking520
lanking520 reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also install autofp8 into our solution stack

@maaquib maaquib force-pushed the lmi-upgrade branch 6 times, most recently from 6c3daf9 to d9207fc Compare July 12, 2024 23:29
@maaquib maaquib marked this pull request as ready for review July 13, 2024 03:39
@maaquib maaquib requested review from zachgk, frankfliu and a team as code owners July 13, 2024 03:39
@maaquib maaquib requested a review from davidthomas426 July 13, 2024 03:39
@maaquib maaquib merged commit cb37ca0 into deepjavalibrary:master Jul 13, 2024
33 of 39 checks passed
@maaquib maaquib deleted the lmi-upgrade branch July 13, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindhuvahinis sindhuvahinis sindhuvahinis left review comments

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

@davidthomas426 davidthomas426 Awaiting requested review from davidthomas426

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maaquib @lanking520 @sindhuvahinis