Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix adapters client testing #2188

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

tosterberg
Copy link
Contributor

Description

Now that response codes are coming back with non-200 values the send_json functions error handling is now occurring prior to and outside of the adapters test handler. Refactored to allow send_json to throw errors, and handle catches appropriately.

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@tosterberg tosterberg requested review from zachgk, frankfliu and a team as code owners July 17, 2024 20:39
@tosterberg tosterberg merged commit 1d8b910 into deepjavalibrary:master Jul 17, 2024
9 checks passed
@tosterberg tosterberg deleted the lora-test-fix branch July 17, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants