add trtllm container update #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
changed the title
frankfliu
reviewed
Jul 18, 2024
| @@ -68,7 +68,7 @@ COPY distribution[s]/ ./ | |||
| RUN mv *.deb djl-serving_all.deb || true | |||
|
|
|||
| # Install CUDNN 8 | |||
| RUN apt-get update && apt-get install -y --no-install-recommends libcudnn8 && rm -rf /var/lib/apt/lists/* | |||
| RUN apt-get update && apt-get install -y --no-install-recommends libcudnn9-cuda-12 && rm -rf /var/lib/apt/lists/* | |||
There was a problem hiding this comment.
Why not just use 12.4.1-cudnn-devel-ubuntu22.04 image directly?
There was a problem hiding this comment.
it also installed libcudnn9-dev-cuda-12, which is around 1GB we don't need that
lanking520
commented
Jul 18, 2024
| ARG cuda_python_version=12.4 | ||
| ARG peft_version=0.10.0 | ||
| ARG triton_version=r24.04 | ||
| ARG trtllm_toolkit_wheel="https://publish.djl.ai/tensorrt-llm/toolkit/tensorrt_llm_toolkit-${trtllm_toolkit_version}-py3-none-any.whl" | ||
| ARG trtllm_wheel="https://djl-ai.s3.amazonaws.com/publish/tensorrt-llm/${trtllm_version}/tensorrt_llm-0.10.0-cp310-cp310-linux_x86_64.whl" | ||
| ARG trtllm_wheel="https://publish.djl.ai/tensorrt-llm/${trtllm_version}/tensorrt_llm-0.11.0-cp310-cp310-linux_x86_64.whl" |
There was a problem hiding this comment.
@ydm-amazon this will allow us to use cloudfront (an AWS services) that do global CDN on the artifacts we have and provide 10x speed up on downloading. Using raw HTTP url for S3 will be slower than that.
tosterberg
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work in progress, will test a build
https://github.com/deepjavalibrary/djl-serving/actions/runs/9984782888