enable full passthrough of vllm engine args, with backwards compatibi… #2639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lity for existing differences with engine agnostic configs
Description
This PR addresses a common pain point with using vllm. We currently restrict the set of engine args that can be passed based on what we expose through VllmRbProperties. This change does the following:
Raising this in draft if people want to start looking and providing feedback. I have the following TODOs still:
I plan on making a similar change for LMI-Dist. I'm starting with VLLM first to keep the change contained, and gather feedback suggestions which I'll take forward for LMI-Dist.
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B