[spark] Add more text predictors #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Mar 5, 2023
| /** @inheritdoc */ | ||
| override def transform(dataset: Dataset[_]): DataFrame = { | ||
| model = new ModelLoader[A, B]($(engine), $(modelUrl), $(inputClass), $(outputClass)) | ||
| model = new ModelLoader[A, B]($(engine), $(modelUrl), $(inputClass), $(outputClass), $(translator), $(translatorFactory), $(tokenizer)) |
There was a problem hiding this comment.
- I think Tokenizer should be a member of transaltorFactory.
- Let's only expose translatorFactory for now, it's a bit confusing have both translator and translatorFactory
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2443 +/- ##
============================================
+ Coverage 72.08% 74.01% +1.92%
- Complexity 5126 6802 +1676
============================================
Files 473 672 +199
Lines 21970 29679 +7709
Branches 2351 3062 +711
============================================
+ Hits 15838 21967 +6129
- Misses 4925 6225 +1300
- Partials 1207 1487 +280
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lanking520
reviewed
Mar 6, 2023
| @@ -0,0 +1,49 @@ | |||
| ///* | |||
There was a problem hiding this comment.
why we leave a file with full comments?
There was a problem hiding this comment.
Checked in by mistake. Removed
xyang16
force-pushed
the
spark
branch
3 times, most recently
from
d3ee098 to
4fe0ddf
Compare
frankfliu
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Add more text predictors