Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load inputShapes in the loadMetadata method of Linear block #2448

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

KexinFeng
Copy link
Contributor

@KexinFeng KexinFeng commented Mar 8, 2023

This aims to solve the issue #2446
As pointed out there in the issue, the loadMetadata method in Linear missed the inputShapes (plural). In this PR it is added.

@KexinFeng KexinFeng requested review from zachgk, frankfliu and a team as code owners March 8, 2023 10:27
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Patch coverage: 75.35% and project coverage change: +1.92 🎉

Comparison is base (bb5073f) 72.08% compared to head (49d9650) 74.01%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2448      +/-   ##
============================================
+ Coverage     72.08%   74.01%   +1.92%     
- Complexity     5126     6801    +1675     
============================================
  Files           473      672     +199     
  Lines         21970    29680    +7710     
  Branches       2351     3062     +711     
============================================
+ Hits          15838    21967    +6129     
- Misses         4925     6225    +1300     
- Partials       1207     1488     +281     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/BaseModel.java 75.83% <0.00%> (+1.86%) ⬆️
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...ain/java/ai/djl/modality/cv/util/NDImageUtils.java 67.10% <0.00%> (+7.89%) ⬆️
... and 642 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KexinFeng KexinFeng merged commit a3a6a90 into deepjavalibrary:master Mar 9, 2023
@KexinFeng KexinFeng deleted the inputShapes branch March 15, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants