Adds a way to check if streaming is supported #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
approved these changes
Apr 10, 2023
lanking520
reviewed
Apr 10, 2023
| @@ -49,6 +49,7 @@ public void testSequential() throws TranslateException { | |||
|
|
|||
| try (Predictor<Double, DoubleStream> predictor = | |||
| model.newPredictor(new TestTranslator())) { | |||
| Assert.assertTrue(predictor.supportsStreaming()); | |||
There was a problem hiding this comment.
does python engine support streaming by default?
There was a problem hiding this comment.
It doesn't really follow this path of using predictor.streamingPredict(). This is more for Java-side streaming. Since the Python engine internally handles the use of ChunkedByteSupplier, I'm not sure if it is worth it to unify the paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about