Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Refactor drawMask() for instance segmentation #3304

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners July 6, 2024 00:53
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 8.16327% with 45 lines in your changes missing coverage. Please review.

Project coverage is 57.91%. Comparing base (725851b) to head (eeab075).
Report is 3 commits behind head on master.

Files Patch % Lines
...pencv/src/main/java/ai/djl/opencv/OpenCVImage.java 0.00% 20 Missing ⚠️
.../java/ai/djl/modality/cv/BufferedImageFactory.java 0.00% 19 Missing ⚠️
.../cv/translator/InstanceSegmentationTranslator.java 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #3304       +/-   ##
=============================================
- Coverage     72.71%   57.91%   -14.81%     
+ Complexity     7361     5757     -1604     
=============================================
  Files           677      677               
  Lines         32561    32594       +33     
  Branches       3433     3441        +8     
=============================================
- Hits          23677    18877     -4800     
- Misses         7258    12261     +5003     
+ Partials       1626     1456      -170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frankfliu frankfliu merged commit bcf8fb3 into deepjavalibrary:master Jul 6, 2024
5 checks passed
@frankfliu frankfliu deleted the mask branch July 6, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants