Support empty strings in default values (#9)

deepmedia · Aug 19, 2024 · a7843f1 · a7843f1
1 parent b3928c7
commit a7843f1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/knee-compiler-plugin/src/main/kotlin/utils/PoetUtils.kt b/knee-compiler-plugin/src/main/kotlin/utils/PoetUtils.kt
@@ -203,7 +203,7 @@ fun IrValueParameter.defaultValueForCodegen(functionExpects: List<IrDeclarationW
     if (expression is IrConst<*>) {
         return when (val kind = expression.kind) {
             is IrConstKind.Null -> CodeBlock.of("null")
-            is IrConstKind.String -> CodeBlock.of(kind.valueOf(expression))
+            is IrConstKind.String -> CodeBlock.of("%S", kind.valueOf(expression))
             else -> CodeBlock.of("%L", kind.valueOf(expression))
             // is IrConstKind.Boolean -> CodeBlock.of(kind.valueOf(expression).toString())
             // is IrConstKind.Int -> CodeBlock.of(kind.valueOf(expression).toString())

diff --git a/...sc/src/androidInstrumentedTest/kotlin/io/deepmedia/tools/knee/tests/DefaultValuesTests.kt b/...sc/src/androidInstrumentedTest/kotlin/io/deepmedia/tools/knee/tests/DefaultValuesTests.kt
@@ -21,4 +21,9 @@ class DefaultValuesTests {
         ConcreteClassWithDefaultValues().withNull()
     }
 
+    @Test
+    fun testDefaultValue_emptyString() {
+        emptyStringDefaultValue()
+    }
+
 }
diff --git a/tests/test-misc/src/backendMain/kotlin/DefaultValuesDefinitions.kt b/tests/test-misc/src/backendMain/kotlin/DefaultValuesDefinitions.kt
@@ -18,4 +18,8 @@ interface BaseInterfaceWithDefaultValues {
     override fun withNull(foo: Int?) {
 
     }
+}
+
+@Knee
+fun emptyStringDefaultValue(foo: String = "") {
 }