forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: optimized cubic spline #4081
Merged
mohanchen
merged 18 commits into
deepmodeling:develop
from
jinzx10:optimize_cubic_spline
May 5, 2024
Merged
Refactor: optimized cubic spline #4081
mohanchen
merged 18 commits into
deepmodeling:develop
from
jinzx10:optimize_cubic_spline
May 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinzx10
changed the title
Refactor: optimize cubic spline
Refactor: optimized cubic spline
Apr 30, 2024
mohanchen
reviewed
May 4, 2024
mohanchen
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
This PR is part of #4079
Unit Tests and/or Case Tests for my changes
The relevant unit tests are re-designed.
What's changed?
The cubic spline class is redesigned to enable faster evaluation in the following two situations:
Any changes of core modules? (ignore if not applicable)
No.