Apply suggestions from code review

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
deepmodeling · Jun 3, 2024 · b376370 · b376370
1 parent 22a98fa
commit b376370
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/doc/train/train-input.rst b/doc/train/train-input.rst
@@ -17,7 +17,7 @@ Training Parameters
 Writing JSON files using Visual Studio Code
 -------------------------------------------
 
-When writing JSON files using Visual Studio Code, one can benefit from IntelliSense and
+When writing JSON files using `Visual Studio Code <https://code.visualstudio.com/>`_, one can benefit from IntelliSense and
 validation by adding a `JSON schema <https://json-schema.org/>`_.
 To do so, in a VS Code workspace, one can generate a JSON schema file for the input file by running the following command:
 

diff --git a/source/tests/common/test_doc_train_input.py b/source/tests/common/test_doc_train_input.py
@@ -16,7 +16,7 @@ def test_rst(self):
         f = io.StringIO()
         with redirect_stdout(f):
             doc_train_input(out_type="rst")
-        self.assertTrue(f.getvalue() != "")
+        self.assertNotEqual(f.getvalue(), "")
 
     def test_json(self):
         f = io.StringIO()