-
Notifications
You must be signed in to change notification settings - Fork 520
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(pt): Change the type of
do_message_passing
from int
to `boo…
…l` in `DeepPotPT` and `DeepSpinPT` classes (#4391) Fix #4366. * Update the type of `do_message_passing` to `bool` in the `DeepPotPT` class and `init` method in `source/api_cc/include/DeepPotPT.h` and `source/api_cc/src/DeepPotPT.cc` * Update the type of `do_message_passing` to `bool` in the `DeepSpinPT` class and `init` method in `source/api_cc/include/DeepSpinPT.h` and `source/api_cc/src/DeepSpinPT.cc` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced error handling for exceptions from the PyTorch library in both `DeepPotPT` and `DeepSpinPT` classes. - Simplified boolean checks for message passing in the `compute` methods of both classes. - **Bug Fixes** - Improved robustness in the `DeepPotPT` constructor to prevent resource leaks during initialization. - **Documentation** - Updated method signatures to reflect changes in parameter types and structures. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
- Loading branch information
1 parent
dbf450f
commit ec6e903
Showing
4 changed files
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters