Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] document equations for se_atten_v2 #3139

Closed
njzjz opened this issue Jan 12, 2024 · 0 comments · Fixed by #3828
Closed

[Docs] document equations for se_atten_v2 #3139

njzjz opened this issue Jan 12, 2024 · 0 comments · Fixed by #3828
Assignees
@iProzd
Labels
Docs

Comments

@njzjz
Copy link
Member

njzjz commented Jan 12, 2024

Summary

The current documentation has equations for se_atten but not for se_atten_v2.

Detailed Description

Add equations for se_atten_v2 to documentation.

Further Information, Files, and Links

No response
@njzjz njzjz added the Docs label Jan 12, 2024
@iProzd iProzd self-assigned this May 1, 2024
@Chengqian-Zhang Chengqian-Zhang mentioned this issue May 28, 2024
Merged
@njzjz njzjz linked a pull request May 28, 2024 that will close this issue
docs: add document equations for se_atten_v2 #3828
Merged
@Chengqian-Zhang Chengqian-Zhang mentioned this issue May 31, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 31, 2024
@Chengqian-Zhang @pre-commit-ci @wanghan-iapcm
docs: add document equations for se_atten_v2 (#3828)
e3acea5 
Solve issue #3139
`"se_atten_v2"` is inherited from `"se_atten"` with the following
parameter modifications:

```json
      "tebd_input_mode": "strip",
      "smooth_type_embedding": true,
      "set_davg_zero": false
```

I add the equations for parameter `"tebd_input_mode"`.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Documentation**
- Detailed the default value and functionality of the
`"tebd_input_mode"` parameter.
- Highlighted the performance superiority of `"se_atten_v2"` over
`"se_atten"`.
  - Specified a model compression requirement for `se_atten_v2`.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
@njzjz njzjz closed this as completed May 31, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 6, 2024
@Chengqian-Zhang @pre-commit-ci @iProzd
Feat: add se_atten_v2to PyTorch and DP (#3840)
c71ece3 
Solve #3831 and #3139
- add `se_atten_v2` to PyTorch and DP
- add document equation for `se_attn_v2`

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new descriptor class with enhanced configuration options
and methods for serialization and deserialization.
- Added new configurable parameters to the descriptor setup for improved
flexibility.

- **Documentation**
- Updated function documentation to reflect new arguments and usage
instructions.

- **Bug Fixes**
- Refined serialization logic to handle new parameters and class types
more accurately.
- Improved error messages for better clarity during serialization
processes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Chenqqian Zhang <100290172+Chengqian-Zhang@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Duo <50307526+iProzd@users.noreply.github.com>
njzjz pushed a commit to njzjz/deepmd-kit that referenced this issue Jul 2, 2024
@Chengqian-Zhang @pre-commit-ci
@wanghan-iapcm @njzjz
docs: add document equations for se_atten_v2 (deepmodeling#3828)
df4d2f0 
Solve issue deepmodeling#3139
`"se_atten_v2"` is inherited from `"se_atten"` with the following
parameter modifications:

```json
      "tebd_input_mode": "strip",
      "smooth_type_embedding": true,
      "set_davg_zero": false
```

I add the equations for parameter `"tebd_input_mode"`.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Documentation**
- Detailed the default value and functionality of the
`"tebd_input_mode"` parameter.
- Highlighted the performance superiority of `"se_atten_v2"` over
`"se_atten"`.
  - Specified a model compression requirement for `se_atten_v2`.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
(cherry picked from commit e3acea5)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz pushed a commit that referenced this issue Jul 3, 2024
@Chengqian-Zhang @pre-commit-ci
@wanghan-iapcm @njzjz
docs: add document equations for se_atten_v2 (#3828)
2b448cb 
Solve issue #3139
`"se_atten_v2"` is inherited from `"se_atten"` with the following
parameter modifications:

```json
      "tebd_input_mode": "strip",
      "smooth_type_embedding": true,
      "set_davg_zero": false
```

I add the equations for parameter `"tebd_input_mode"`.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Documentation**
- Detailed the default value and functionality of the
`"tebd_input_mode"` parameter.
- Highlighted the performance superiority of `"se_atten_v2"` over
`"se_atten"`.
  - Specified a model compression requirement for `se_atten_v2`.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
(cherry picked from commit e3acea5)
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
@Chengqian-Zhang @pre-commit-ci @wanghan-iapcm
docs: add document equations for se_atten_v2 (deepmodeling#3828)
68068a0 
Solve issue deepmodeling#3139
`"se_atten_v2"` is inherited from `"se_atten"` with the following
parameter modifications:

```json
      "tebd_input_mode": "strip",
      "smooth_type_embedding": true,
      "set_davg_zero": false
```

I add the equations for parameter `"tebd_input_mode"`.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Documentation**
- Detailed the default value and functionality of the
`"tebd_input_mode"` parameter.
- Highlighted the performance superiority of `"se_atten_v2"` over
`"se_atten"`.
  - Specified a model compression requirement for `se_atten_v2`.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
@Chengqian-Zhang @pre-commit-ci @iProzd
Feat: add se_atten_v2to PyTorch and DP (deepmodeling#3840)
80d73d2 
Solve deepmodeling#3831 and deepmodeling#3139
- add `se_atten_v2` to PyTorch and DP
- add document equation for `se_attn_v2`

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new descriptor class with enhanced configuration options
and methods for serialization and deserialization.
- Added new configurable parameters to the descriptor setup for improved
flexibility.

- **Documentation**
- Updated function documentation to reflect new arguments and usage
instructions.

- **Bug Fixes**
- Refined serialization logic to handle new parameters and class types
more accurately.
- Improved error messages for better clarity during serialization
processes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Chenqqian Zhang <100290172+Chengqian-Zhang@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Duo <50307526+iProzd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iProzd iProzd

Labels
Docs
Projects
No open projects
DeePMD-3.0.0 beta release
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add document equations for se_atten_v2 Chengqian-Zhang/deepmd-kit
2 participants
@njzjz @iProzd