Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] finetune with fparam/aparam #3256

Closed
njzjz opened this issue Feb 11, 2024 Discussed in #3255 · 1 comment · Fixed by #3313
Closed

[BUG] finetune with fparam/aparam #3256

njzjz opened this issue Feb 11, 2024 Discussed in #3255 · 1 comment · Fixed by #3313
Labels

Comments

@njzjz
Copy link
Member

njzjz commented Feb 11, 2024

Discussed in #3255

Originally posted by chtchelkatchev February 10, 2024
I pretrained the deepmd potential with fparam using the descriptor se_atten_v2 and deepmd=2.2.7. Then an attempt was made to finetune this potential on a new database with fparam, which led to an error message: "... in _prepare_feed_dict assert fparam is not None ... AssertionError". Without fparam fintuning works well. The ussue appears only with fparam. Does finetuning work with fparam?

@njzjz njzjz added the bug label Feb 11, 2024
@njzjz
Copy link
Member Author

njzjz commented Feb 11, 2024

We have to handle fparam/aparam in dp test, dp model-devi, and finetune. Thus, it will be more reasonable to add a new method to do it.

@njzjz njzjz linked a pull request Feb 20, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Feb 21, 2024
Fix #3256.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz closed this as completed Feb 21, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Bugfixes for DeePMD-kit Feb 21, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this issue Apr 6, 2024
Fix deepmodeling#3256.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit d629616)
njzjz added a commit that referenced this issue Apr 6, 2024
Fix #3256.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
(cherry picked from commit d629616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant