Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(wheel): unpin h5py on aarch64 #3864

Closed
github-actions bot opened this issue Jun 11, 2024 · 1 comment · Fixed by #4176
Closed

build(wheel): unpin h5py on aarch64 #3864

github-actions bot opened this issue Jun 11, 2024 · 1 comment · Fixed by #4176
Assignees
@njzjz
Labels
branch: devel todo comment type: todo upstream

Comments

@github-actions
Copy link

Revert after h5py/h5py#2408 is fixed;
or set UV_PREFER_BINARY when astral-sh/uv#1794 is resolved.
3.6.0 is the first version to have aarch64 wheels.

Line: 159

deepmd-kit//backend/find_tensorflow.py

Lines 156 to 166 in a7ab1af

"tensorflow; platform_machine=='aarch64' or (platform_machine=='arm64' and platform_system == 'Darwin')",
# https://github.com/tensorflow/tensorflow/issues/61830
"tensorflow-cpu!=2.15.*; platform_system=='Windows'",
# TODO: build(wheel): unpin h5py on aarch64
# Revert after https://github.com/h5py/h5py/issues/2408 is fixed;
# or set UV_PREFER_BINARY when https://github.com/astral-sh/uv/issues/1794 is resolved.
# 3.6.0 is the first version to have aarch64 wheels.
"h5py>=3.6.0,<3.11.0; platform_system=='Linux' and platform_machine=='aarch64'",
*extra_requires,
],
"gpu": [

@njzjz njzjz self-assigned this Jun 11, 2024
@njzjz njzjz added the upstream label Sep 11, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this issue Oct 1, 2024
@njzjz
fix: unpin h5py on aarch64
8b6089b 
Fix deepmodeling#3864.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz mentioned this issue Oct 1, 2024
Merged
@njzjz njzjz linked a pull request Oct 1, 2024 that will close this issue
fix: unpin h5py on aarch64 #4176
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2024
@njzjz
fix: unpin h5py on aarch64 (#4176)
a9ffccb 
Fix #3864.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced logic for detecting TensorFlow installation paths and
requirements.
	- Improved error handling for TensorFlow version detection.

- **Bug Fixes**
- Adjusted compatibility specifications for the `h5py` dependency on
aarch64 architecture.

- **Documentation**
- Updated comments to clarify changes in TensorFlow detection and
compatibility issues.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Oct 2, 2024

Closed in commit a9ffccb

@github-actions github-actions bot closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njzjz njzjz

Labels
branch: devel todo comment type: todo upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unpin h5py on aarch64 njzjz/deepmd-kit
1 participant
@njzjz