Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] refactor the function interface in deepmd/pt/entrypoints/main.py #3934

Closed
iProzd opened this issue Jul 1, 2024 · 0 comments · Fixed by #4225
Closed

[Feature Request] refactor the function interface in deepmd/pt/entrypoints/main.py #3934

iProzd opened this issue Jul 1, 2024 · 0 comments · Fixed by #4225
Assignees
Milestone

Comments

@iProzd
Copy link
Collaborator

iProzd commented Jul 1, 2024

Summary

Refactor the function interface in deepmd/pt/entrypoints/main.py, to use explicit input instead of FLAGS.

Detailed Description

see above.

Further Information, Files, and Links

No response

@iProzd iProzd self-assigned this Sep 26, 2024
@iProzd iProzd moved this to mustfix in DeePMD-kit V3.0.0 RC Sep 26, 2024
@njzjz njzjz added this to the v3.0.0 milestone Sep 26, 2024
@iProzd iProzd linked a pull request Oct 16, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Oct 16, 2024
Fix #3934.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced clarity and usability of the training process with explicit
parameters for model training, freezing, and bias changing functions.
- Improved function interfaces streamline user interactions and
understanding.

- **Bug Fixes**
- Resolved issues related to parameter handling by transitioning from a
flags-based system to a more structured approach.

- **Refactor**
- Updated function signatures for better readability and
maintainability, improving the overall structure of the code.
- Simplified the freezing mechanism in tests by removing the use of a
`Namespace` object.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@njzjz njzjz closed this as completed Oct 16, 2024
@github-project-automation github-project-automation bot moved this from mustfix to Done in DeePMD-kit V3.0.0 RC Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants