Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PT: DpLoaderSet seems setting a fixed seed? #4011

Closed
njzjz opened this issue Jul 23, 2024 · 0 comments · Fixed by #4015
Closed

[BUG] PT: DpLoaderSet seems setting a fixed seed? #4011

njzjz opened this issue Jul 23, 2024 · 0 comments · Fixed by #4015
Assignees
Labels

Comments

@njzjz
Copy link
Member

njzjz commented Jul 23, 2024

I notice that in the DpLoaderSet class, there is a seed argument, with the default value of 10.

def __init__(
self,
systems,
batch_size,
type_map,
seed=10,
shuffle=True,
):
setup_seed(seed)
if isinstance(systems, str):

When constructing DpLoaderSet, no seed is passed, so it seems that it always sets a seed of 10, which does not make sense.

validation_data_single = (
DpLoaderSet(
validation_systems,
validation_dataset_params["batch_size"],
model_params_single["type_map"],
)
if validation_systems
else None
)
train_data_single = DpLoaderSet(
training_systems,
training_dataset_params["batch_size"],
model_params_single["type_map"],
)
return (

@njzjz njzjz added the bug label Jul 23, 2024
@iProzd iProzd linked a pull request Jul 24, 2024 that will close this issue
@njzjz njzjz closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants