fix(pt): use user seed in DpLoaderSet

[iProzd]

Summary by CodeRabbit

• New Features

  • Introduced a seed parameter for enhanced control over randomness in the training process.
  • Improved randomness handling for distributed training setups to ensure unique batch sequences.

• Bug Fixes

  • Enhanced robustness in seed setup during initialization to prevent unnecessary function calls with a None value.

• Chores

  • Streamlined the random seed management by removing redundant seed-setting logic in training processes.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes enhance randomness control in the training process by adding a seed parameter to the prepare_trainer_input_single function, which allows for unique random seeds in distributed setups, improving reproducibility. Additionally, the get_lr function has had explicit random seed settings removed, streamlining the code but raising potential consistency concerns. A conditional check in the dataloader ensures that seed setup only occurs when a valid seed is provided.

Changes

Files	Change Summary
deepmd/pt/entrypoints/main.py	Added an optional seed parameter to prepare_trainer_input_single for improved randomness control in training.
deepmd/pt/train/training.py	Removed explicit seed-setting logic from get_lr, streamlining randomness management but potentially affecting reproducibility.
deepmd/pt/utils/dataloader.py	Updated __init__ to conditionally call setup_seed, ensuring it only executes when a valid seed is provided.

Sequence Diagram(s)

sequenceDiagram
    participant Trainer as Trainer
    participant DataLoader as DataLoader
    participant Model as Model

    Trainer->>DataLoader: Prepare training input with seed
    DataLoader->>Model: Set up data with provided seed
    Model-->>Trainer: Return prepared data

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8786f20 and 233ee65.

Files selected for processing (1)

• deepmd/pt/entrypoints/main.py (6 hunks)

Files skipped from review as they are similar to previous changes (1)

• deepmd/pt/entrypoints/main.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (5dd0062) to head (233ee65).
Report is 109 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #4015      +/-   ##
==========================================
- Coverage   82.92%   82.92%   -0.01%     
==========================================
  Files         522      522              
  Lines       51010    51009       -1     
  Branches     3023     3023              
==========================================
- Hits        42301    42300       -1     
+ Misses       7767     7765       -2     
- Partials      942      944       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.